2007/7/27, Sam Ruby: > > I realize that this doesn't directly answer your question, but what I > think is that the tests should reflect how we expect the software to > behave TODAY. If there are things that we would like to see behave > different in the future, the tests can be coded and commented out with # > TODO or # XXX or the like.
I'll do it (in test_whitespace_stripper and test_formfiller), but... > Why? Because I see unit tests as a way of enabling myself and others to > make changes that we think won't affect other behaviors by enabling us > to verify that such is the case. > > This means that if a given function is NotImplemented at the moment at > least, then the expected result should be NotImplemented. > > If a space (or lack thereof) causes no harm in <!DOCTYPE>s, then lets > just pick to either always include it or always exclude it, and then > make all the code consistent. ...the "problem" is that testdata/ files are used by other projects too, at least testdata/tokenizer, testdata/tree-construction and testdata/encoding: Henri's Java-based HTML5 parser [1] and Twintsam (which I'm resurrecting) But actually, r908 changed the test file back to using a space *because it's what's documented in the wiki* [2]. I think the wiki and the tests should be updated to include DOCTYPE's publicId and systemId (and quirksmode?); so every implementation should change too ;-) [1] http://svn.versiondude.net/whattf/htmlparser/trunk/ [2] http://wiki.whatwg.org/wiki/Parser_tests -- Thomas Broyer --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "html5lib-discuss" group. To post to this group, send email to html5lib-discuss@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/html5lib-discuss?hl=en-GB -~----------~----~----~----~------~----~------~--~---
RetroSearch is an open source project built by @garambo | Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4