On Feb 3, 2019, at 13:03, Antoine Pitrou <solipsis at pitrou.net> wrote: > > I'd like to ask for the reversion of the changes done in > https://github.com/python/cpython/pull/11664 > > The reason is simple: the PR isn't complete, it lacks docs and tests. > It also didn't pass any review (this was pointed by Ronald), even > though it adds 1300 lines of code. No programmer is perfect, so it's > statistically likely that the PR is defective. I concur. I actually think CI shouldn’t even pass without sufficiently covering tests and docs (sans a “trivial” or other short circuiting label), but that might be unpopular. -Barry -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: Message signed with OpenPGP URL: <http://mail.python.org/pipermail/python-dev/attachments/20190203/fac72696/attachment.sig>
RetroSearch is an open source project built by @garambo | Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4