On Mon, Feb 23, 2015 at 1:16 PM, Brett Cannon <brett at python.org> wrote: > Overall I like this and don't see any reason not to accept it, so +1. I do > have a couple comments/questions on the module API, though. > > On Mon Feb 23 2015 at 12:45:28 PM Paul Moore <p.f.moore at gmail.com> wrote: >> >> <SNIP> >> >> >> ``set_interpreter(archive, new_archive, interpreter=None)`` >> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ >> >> Modifies the *archive*'s shebang line to contain the specified >> interpreter, and writes the updated archive to *new_archive*. If the >> *interpreter* is ``None``, removes the shebang line. > > > Should new_archive default to None to allow for in-place editing? > > -Brett That would be cool but more work. Unless the length of the new shebang is <= the old one, the zip file contents have to be moved out of the way.
RetroSearch is an open source project built by @garambo | Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4