2015-02-13 11:19 GMT+01:00 Paul Moore <p.f.moore at gmail.com>: > On 13 February 2015 at 10:07, Victor Stinner <victor.stinner at gmail.com> wrote: >> => IMO the best option is to take the C implementation. What do you think? > > FWIW (as I'm not a core dev) I agree. The Windows speedup is huge, and > well worth adding the code. I'm assuming that the majority of the C > code is cross-platform, so we're not adding a big chunk of code > needing *both* Windows and C skills to maintain (any dev with C skills > could handle it). > > Paul The patch can be read here: http://bugs.python.org/file36963/scandir-2.patch Or using Rietveld: http://bugs.python.org/review/22524/#ps13104 The C code is quite simple. It takes 800 lines because C code is more "verbose" than Python code. Manipulate strings, manage memory, take care of the reference counter, etc. just takes more lines. Victor
RetroSearch is an open source project built by @garambo | Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4