2012/5/4 Larry Hastings <larry at hastings.org>: > + if (times && (times != Py_None)) { > > Conditions in parenthesis like this is not style. > > > Can you point me to where this is described in PEP 7? I can't find it. It's not explicitly stated, but there is the following nice example: if (type->tp_dictoffset != 0 && base->tp_dictoffset == 0 && type->tp_dictoffset == b_size && (size_t)t_size == b_size + sizeof(PyObject *)) return 0; /* "Forgive" adding a __dict__ only */ There's also the consistency with surrounding code imperative. -- Regards, Benjamin
RetroSearch is an open source project built by @garambo | Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4