Antoine Pitrou wrote: > Hello Mark, > > I think the PEP should explain what happens when a keys table needs > resizing when setting an object's attribute. If the object is the only instance of a class, it remains split, otherwise the table is combined. Most OO code will set attributes in the __init__ method so all attributes are set before a second instance is created. For more complex use patterns, it is impossible to know what is the best approach, so the implementation allows extra insertions up to the point of a resize when it reverts to the combined table (non-shared keys). (This may not be the case in the bitbucket repository, I'll push the newer version tomorrow). > Reading the implementation, it seems the sharing can disappear > definitely, which seems a bit worrying. It is immediately re-split (to allow sharing) when only one instance of the class exists. I've implemented it that way (resize->combined then re-split) as most resizes (999 out of 1000) will be of combined tables, and I don't want to complicate the fast path. Cheers, Mark.
RetroSearch is an open source project built by @garambo | Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4