RetroSearch Browse

Sat Mar 5 17:26:53 CET 2011 · https://mail.python.org/pipermail/python-dev/2011-March/108735.html

On 04.03.2011 22:56, Antoine Pitrou wrote:
> On Fri, 04 Mar 2011 22:45:24 +0100
> "Martin v. Löwis" <martin at v.loewis.de> wrote:
>> > It's not really needed; but since it works with 6+ hex digits there might
>> > be false positives.
>> 
>> I searched the messages, and it turns out that primarily long numbers
>> would give false positives:
>> 
>>  Python 1.6a2 (#7, Apr 24 2000, 23:02:54)  [GCC pgcc-2.91.66 19990314
>>  minidom (as the proposed documentation in patch 101821 explains) does
>>  Closed as Duplicate; see bug 435026 for details.  It's an
>>  the test is extended to 2000000 objects on my machine
>>  IRIX rattler 6.5 10120734 IP32
>>  hash("DNSSEC") == 8704052292078464
>>  [New Thread 2305843009213881680 (LWP 23166)]
>> 
>> So I guess mandating square brackets is reasonable - alternatively,
>> mandating a fixed length could have worked as well, I guess.
> 
> The two forms used in hg's output are 10-digit and 40-digit ids
> (the latter only with --debug, IIUC). The only reason to use another
> form (especially shorter) is if you type the changeset id by hand
> rather than paste it, which must not be very common.
> 
> And if there are false positives from time to time, well they'll just
> link to 404s (unknown ids). I don't think that's an important issue.

OK, I changed the code to only allow 12 (not 10) or 40 hex digits, but
without parentheses.

Georg

Home - News ( United States | United Kingdom | Italy | Germany ) - Football scores

Showing content from https://mail.python.org/pipermail/python-dev/2011-March/108735.html below:

[Python-Dev] rXXX links in the bug tracker after the migration to Mercurial