RetroSearch Browse

Wed Nov 24 12:37:54 CET 2010 · https://mail.python.org/pipermail/python-dev/2010-November/105966.html

On Wed, 24 Nov 2010 11:39:23 +0100 (CET)
armin.rigo <python-checkins at python.org> wrote:
> Author: armin.rigo
> Date: Wed Nov 24 11:39:23 2010
> New Revision: 86726
> 
> Log:
> A no-op change.  It looks like this call was not meant to be a recursive
> call, but just call the helper (which the recursive call ends up doing).

Since it's allegedly a no-op change, it doesn't come with a test, and
2.7.1 is in rc phase, is it really the right time to do it? What is the
motivation for it?

Thanks

Antoine.

> 
> 
> Modified:
>    python/branches/release27-maint/Objects/setobject.c
> 
> Modified: python/branches/release27-maint/Objects/setobject.c
> ==============================================================================
> --- python/branches/release27-maint/Objects/setobject.c	(original)
> +++ python/branches/release27-maint/Objects/setobject.c	Wed Nov 24 11:39:23 2010
> @@ -1858,7 +1858,7 @@
>          tmpkey = make_new_set(&PyFrozenSet_Type, key);
>          if (tmpkey == NULL)
>              return -1;
> -        rv = set_contains(so, tmpkey);
> +        rv = set_contains_key(so, tmpkey);
>          Py_DECREF(tmpkey);
>      }
>      return rv;

Home - News ( United States | United Kingdom | Italy | Germany ) - Football scores

Showing content from https://mail.python.org/pipermail/python-dev/2010-November/105966.html below:

[Python-Dev] r86726 - python/branches/release27-maint/Objects/setobject.c