RetroSearch Browse

Fri Jan 9 07:13:08 CET 2009 · https://mail.python.org/pipermail/python-dev/2009-January/084968.html

On Thu, Jan 8, 2009 at 17:42, Benjamin Peterson <benjamin at python.org> wrote:
> On Thu, Jan 8, 2009 at 7:39 PM, Brett Cannon <brett at python.org> wrote:
>> On Thu, Jan 8, 2009 at 17:31, Benjamin Peterson <benjamin at python.org> wrote:
>>> On Thu, Jan 8, 2009 at 2:52 PM, Brett Cannon <brett at python.org> wrote:
>>>> On Thu, Jan 8, 2009 at 12:43, Nick Coghlan <ncoghlan at gmail.com> wrote:
>>>>>
>>>>> Even if we do adopt such a rule, C patches posted to the tracker should
>>>>> still try to avoid including pure whitespace changes though - leaving
>>>>> the whitespace changes in the patch tends to lead to patches that look
>>>>> like "remove function body, add different function body" when only a
>>>>> couple of lines have actually had significant changes.
>>>>>
>>>>
>>>> That's fine with me. Correcting whitespace can be considered a committer's job.
>>>
>>> Maybe a rule could be added to Tools/scripts/patchcheck.py?
>>
>> To do what? Re-indent automatically? Or notify the person that there
>> seems to be a need to re-indent some code?
>
> I was thinking about notifying the person that their indentation was
> wrong or they had trailing whitespace. Fixing it is bonus. :)

Supporting C and header files was a plan of mine from the beginning.
We will see when I get to it. =)

-Brett

Home - News ( United States | United Kingdom | Italy | Germany ) - Football scores

Showing content from https://mail.python.org/pipermail/python-dev/2009-January/084968.html below:

[Python-Dev] Fixing incorrect indentations in C files (Decoder functions accept str in py3k)