RetroSearch Browse

Thu Sep 4 16:39:46 CEST 2008 · https://mail.python.org/pipermail/python-dev/2008-September/082226.html

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sep 4, 2008, at 9:45 AM, skip at pobox.com wrote:

>
>    Barry> Or did he commit Mark's patch from bug 3772?  If so, that  
> would
>    Barry> count as a reviewed patch.
>
> The checkin message says issue 3726:
>
>    Author: vinay.sajip
>    Date: Wed Sep  3 11:20:05 2008
>    New Revision: 66180
>
>    Log:
>    Issue #3726: Allowed spaces in separators in logging  
> configuration files.
>
>    Modified:
>       python/trunk/Lib/logging/config.py
>       python/trunk/Lib/test/test_logging.py
>       python/trunk/Misc/NEWS
>
> I noticed because someone else (Brett?) questioned the apparent lack  
> of
> review.

Yep, that's a different issue.  Unless someone wants to vouch for the  
committed patch after the fact, could someone please revert the change  
and contact Vinay to get a proper fix reviewed?  I noticed that he  
says in the tracker issue that what was committed was modified from  
the posted patch.

- -Barry

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Darwin)

iQCVAwUBSL/zMnEjvBPtnXfVAQJY3QP+LNXhx1YGuCHSw/D2n0yVBj1PLLUbgYnp
k/+zWWmvIRc8YSApV1YyYR4iXfqqYFoi1SH0eh7F1k9+2CZ51HHD0p6CZ0Eb1FQ2
405ocxT28R3UR/E0ozxFca3IuNhGPR2FI/BCfsLrdrA3UtHA4XvZMDvM3KxEMarl
9WdYgop/I8Y=
=b6Ry
-----END PGP SIGNATURE-----

Home - News ( United States | United Kingdom | Italy | Germany ) - Football scores

Showing content from https://mail.python.org/pipermail/python-dev/2008-September/082226.html below:

[Python-Dev] [Python-3000] Not releasing rc1 tonight