RetroSearch Browse

Sat Aug 19 10:16:11 CEST 2006 · https://mail.python.org/pipermail/python-dev/2006-August/068384.html

On Saturday 19 August 2006 15:28, Georg Brandl wrote:
> John J Lee wrote:
> > Revision 50842 made a change to an undocumented interface of urllib2 that
> > I'm sure will break real code.
> >
> > Patch 1542948 reverts the part of that commit that applied to urllib2,
> > and adds a one-line fix in its place that addresses the problem that
> > 50842 fixed.
> >
> > Details are on the patch tracker:
> >
> > http://python.org/sf/1542948
> >
> >
> > Can somebody commit this for 2.5?
>
> As the committer of the original patch, I have reviewed it and I'm for it.

I agree with Neal's comment - this needs tests to make sure it doesn't break 
again. It's OK to apply it with the tests. 

Anthony

-- 
Anthony Baxter     <anthony at interlink.com.au>
It's never too late to have a happy childhood.

Home - News ( United States | United Kingdom | Italy | Germany ) - Football scores

Showing content from https://mail.python.org/pipermail/python-dev/2006-August/068384.html below:

[Python-Dev] One-line fix for urllib2 regression