RetroSearch Browse

Fri Aug 18 00:44:58 CEST 2006 · https://mail.python.org/pipermail/python-dev/2006-August/068353.html

High-level remark: this seems to need more unit tests. Perhaps TDD
(test-driven design) would be the best approach to obtaining a correct
patch?

--Guido

On 8/17/06, Armin Rigo <arigo at tunes.org> wrote:
> Hi Neal,
>
> On Wed, Aug 16, 2006 at 10:26:09PM -0700, Neal Norwitz wrote:
> > @@ -2367,7 +2374,9 @@
> >       compiler_use_next_block(c, end);
> >       if (!compiler_push_fblock(c, FINALLY_END, end))
> >               return 0;
> > +     c->c_in_finally = 1;
> >       VISIT_SEQ(c, stmt, s->v.TryFinally.finalbody);
> > +     c->c_in_finally = 0;
> >       ADDOP(c, END_FINALLY);
> >       compiler_pop_fblock(c, FINALLY_END, end);
>
> Without more inspection, I'd say that this looks like it won't do the
> right thing about nested finally's, as in:
>
>        ...
>    finally:
>        try:
>            ...
>        finally:
>            ...
>        continue
>
>
> A bientot,
>
> Armin
> _______________________________________________
> Python-Dev mailing list
> Python-Dev at python.org
> http://mail.python.org/mailman/listinfo/python-dev
> Unsubscribe: http://mail.python.org/mailman/options/python-dev/guido%40python.org
>

-- 
--Guido van Rossum (home page: http://www.python.org/~guido/)

Home - News ( United States | United Kingdom | Italy | Germany ) - Football scores

Showing content from https://mail.python.org/pipermail/python-dev/2006-August/068353.html below:

[Python-Dev] 2.4 & 2.5 beta 3 crash