Thomas> (I did write the test_pty/test_openpty modules with this in Thomas> mind, though: Thomas> ## # Please uncomment these if os.isatty() is added. Thomas> ## if not os.isatty(master_fd): Thomas> ## raise TestFailed, "master_fd is not a tty" Thomas> ## if not os.isatty(slave_fd): Thomas> ## raise TestFailed, "slave_fd is not a tty" Thomas> So if you accept the patch, please uncomment those lines ;) Will do. Thomas> However, isatty() is a *very* simple wrapper around a very basic Thomas> C function, so I didn't think it warranted a test case. (Like Thomas> you pointed out, none of the other functions in posixmodule have Thomas> test cases.) My message wasn't motivated so much with the missing test case for isatty, but that there are no regression tests at all for os, posix or sys. Skip
RetroSearch is an open source project built by @garambo | Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4