Christian Tismer wrote: > > Vladimir Marangozov wrote: > > > > Maybe unrelated, but this code does not handle the case when > > PyList_Append fails. If it fails, the object needs to be deallocated > > as usual. Looking at the macros, I don't see how you can do that > > because Py_TRASHCAN_SAFE_END, which calls the above function, > > occurs after the finalization code... > > Yes, it does not handle this case for the following reasons: > ... Not enough good reasons to segfault. I suggest you move the call to _PyTrash_deposit_object in TRASHCAN_BEGIN and invert the condition there. -- Vladimir MARANGOZOV | Vladimir.Marangozov@inrialpes.fr http://sirac.inrialpes.fr/~marangoz | tel:(+33-4)76615277 fax:76615252
RetroSearch is an open source project built by @garambo | Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4