Home - News ( United States | United Kingdom | Italy | Germany ) - Football scores

Showing content from https://lists.gnu.org/archive/html/emacs-devel/2022-11/msg00625.html below:

Re: Understanding end-of-defun

> On Nov 10, 2022, at 2:49 PM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> 
>>> I haven't had a chance to try it out, but it looks good to me, tho
>>> `beginning-of-defun-raw` doesn't mention anything about its return value
>>> in the its docstring, so we may want to tweak that docstring (and
>>> review its code to make sure that it indeed returns the value we need
>>> in all cases, tho I suspect you've done so already).
>> 
>> (Sorry for the delay) Yes, it returns nil in all cases. Pretty sure that’s
>> the intent from the very beginning (looking at git logs). How about
>> this patch?
> 
> LGTM, thank you!

I pushed this to feature/tree-sitter. I looked at tests for end-of-defun, the 
only one I found runs fine. I could add a test for this change but I don’t know 
what we’ll test for.

> PS: I'm very happy to work with you: I just babble about and you
>    go and do the grunt work.  Half kidding, obviously, but really,
>    I appreciate it, thank you.
> 

Oh thank you! That made my day :-)

Yuan

• Re: Understanding end-of-defun, Yuan Fu, 2022/11/10
  • Re: Understanding end-of-defun, Stefan Monnier, 2022/11/10
    • Re: Understanding end-of-defun, Yuan Fu <=

• Prev by Date: Re: Tree sitter support for C-like languages
• Next by Date: Re: Tree sitter support for C-like languages
• Previous by thread: Re: Understanding end-of-defun
• Next by thread: Re: [nongnu] elpa/idris-mode e7e2a6c3bc 3/8: Remove dependency on if-let* defined in subr-x
• Index(es):
  • Date
  • Thread

RetroSearch is an open source project built by @garambo | Open a GitHub Issue

Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo

HTML: 3.2 | Encoding: UTF-8 | Version: 0.7.4