Right now a node's .parent property is loosely typed as TESTree.Node. This is pretty sucky as it means that users need to either add unnecessary logic or explicit casts to refine types in some cases.
There are a number of nodes wherein we know exactly what the parent node will always be due to the defined structure of the AST.
For example, we know that a VariableDeclarator will always have a VariableDeclaration parent.
We should define some of these simpler relationships in our types to improve the experience of consuming the AST types.
Some cases we can define:
AccessorProperty has parent ClassBody ( feat(ast-spec): add parent property to AccessorProperty node types #9487)CatchClause has parent TryStatementClassBody has parent ClassDeclaration | ClassExpression | TSAbstractClassDeclarationExportSpecifier has parent ExportNamedDeclarationImportAttribute has parent ImportDeclaration | ImportExpressionImportDefaultSpecifier has parent ImportDeclarationImportNamespaceSpecifier has parent ImportDeclarationImportSpecifier has parent ExportAllDeclaration | ExportNamedDeclaration | ImportDeclarationJSXAttribute has parent JSXOpeningElementJSXClosingElement has parent JSXElementJSXClosingFragment has parent JSXFragmentJSXOpeningElement has parent JSXElementJSXOpeningFragment has parent JSXFragmentJSXSpreadAttribute has parent JSXOpeningElementMethodDefinition has parent ClassBodyProperty has parent ObjectExpression | ObjectPatternPropertyDefinition has parent ClassBodySpreadElement has parent ArrayExpression | CallExpression | ObjectExpressionStaticBlock has parent ClassBodySwitchCase has parent SwitchStatementTemplateElement has parent TemplateLiteral | TSTemplateLiteralTypeTSAbstractAccessorProperty has parent ClassBodyTSAbstractMethodDefinition has parent ClassBodyTSAbstractPropertyDefinition has parent ClassBodyTSCallSignatureDeclaration has parent TSInterfaceBody | TSTypeLiteralTSConstructSignatureDeclaration has parent TSInterfaceBody | TSTypeLiteralTSClassImplements has parent ClassDeclaration | ClassExpressionTSEnumMember has parent TSEnumDeclarationTSIndexSignature has parent ClassBody | TSInterfaceBody | TSTypeLiteralTSInterfaceBody has parent TSInterfaceDeclarationTSInterfaceHeritage has parent TSInterfaceBodyTSMethodSignature has parent TSInterfaceBody | TSTypeLiteralTSModuleBlock has parent TSModuleDeclarationTSParameterProperty has parent FunctionLikeTSPropertySignature has parent TSInterfaceBody | TSTypeLiteralTSTypeParameter has parent TSInferType | TSTypeParameterDeclaration | TSMappedTypeVariableDeclarator has parent VariableDeclaration ( feat(typescript-estree): restrict variable declarator definite/init combinations #9228)Note: the implementor should double check that I've written these correctly by comparing them against the AST types.
The import thing to note is that we shouldn't define all of the relationships that exist - just a subset of them that we can easily statically define and maintain. I'd probably put a rule around ~3 parent types being the maximum.
Zamiell, kirkwaiblinger and auvredomril1 and JoshuaKGoldberg
RetroSearch is an open source project built by @garambo | Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4