For me, I care about the ability of batch processing a ton of files at once. The primary reason I use the original library is that it uses the native batch mode of exiftool in Perl (kind of opening a server and keep sending it commands.) I’m not sure it is related to the things you’re modifying, but I can keep my own fork for that purpose.
oh, no, I'm not removing the native batch mode. That's the best part!
The -stay_open
flag is still there. the *_batch
functionality I'm talking about is the get_metadata_batch()
and get_metadata()
helper methods that smarnach had added to the ExifTool class for people to use easier. As he said in the other thread, he really designed the code for illustration purposes, not really considering all the possible ways to break it lol.
I'm good at breaking things :). Just filed an issue with CPython earlier today because I can't figure out why ExifTool class hangs the interpreter on __del__
in Windows (it appears to "potentially" be a bug in CPython 3.8-3.10, but the debugging part is beyond me)
P.S. By my own test, that batch mode is still much slower than using the native batch mode of exiftool on the command line.
how are you using the batch mode on the command line. Can you write a simple benchmark for me to test against? I actually noticed how smarnach optimized memory and resource management lately as I've been trying to tweak the code. I might be able to look into optimizing it if it's much slower. I wonder why it would be...
Example of the _batch stuff I'm talking aboutEdit: If you want to see what I mean by removing the _batch
function and combining it into a single function you can see the def get_tags(self, in_tags, in_files)
in the latest version on the v0.5 branch
This combines the functionality of the original def get_tags_batch(self, tags, filenames) and the original def get_tags(self, tags, filename) into one very usable (and error-checked to death) function with a consistent return value
RetroSearch is an open source project built by @garambo | Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4