This issue is for tracking cherry-picks to the release branch. Following is release branch for the 2.3.1 release.
Our plan from this point is roughly the following:
Only issues that have ‘cherry-picks’ in this tracker will be considered for the release.
Cherry-Pick CriteriaPhase 1 (until 5/27):
The Releng team relies on the cherry pick process to manage risk to release quality, i.e. by porting a small set of commit from trunk that are "must-have" into the release branch, we limit the change to the minimal to address pressing issues. Thus, not everything a developer land into the trunk will make it into the release. So, please consider the criteria below and follow the cherry picking process. Only low-risk changes may be cherry-picked from master:
Any other change requires special dispensation from the release managers (currently @atalman, @huydhn, @PaliC, @malfet). If this applies to your change please write "Special Dispensation" in the "Criteria Category:" template below and explain.
Phase 2 (after 5/27):
Note that changes here require us to rebuild a Release Candidate and restart extended testing (likely delaying the release). Therefore, the only accepted changes are Release-blocking critical fixes for: silent correctness, backwards compatibility, crashes, deadlocks, (large) memory leaks
Changes will likely require a discussion with the larger release team over VC or Slack.
Cherry-Pick ProcessEnsure your PR has landed in master. This does not apply for release-branch specific changes (see Phase 1 criteria).
Create (but do not land) a PR against the release branch.
# Find the hash of the commit you want to cherry pick # (for example, abcdef12345) git log git fetch origin release/2.3 git checkout release/2.3 git cherry-pick abcdef12345 # Submit a PR based against 'release/2.3' either: # via the GitHub UI git push my-fork # via the GitHub CLI gh pr create --base release/2.3
Make a request below with the following format:
Link to landed trunk PR (if applicable):
*
Link to release branch PR:
*
Criteria Category:
*
NOTE: Our normal tools (ghstack / ghimport, etc.) do not work on the release branch.
See HUD 2.3
Versions2.3.1
RetroSearch is an open source project built by @garambo | Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4