+12
-4
lines changedFilter options
+12
-4
lines changed Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
1 1
Changelog
2 2
=========
3 3 4 + 5 +
1.8.1
6 +
-----
7 + 8 +
- Ensure node's `splinter_failure` always exists (bubenkoff, pelme)
9 +
- Correctly handle skipped tests (bubenkoff, schtibe)
10 + 11 + 4 12
1.8.0
5 13
-----
6 14
@@ -1,2 +1,2 @@
1 1
"""pytest-splinter package."""
2 -
__version__ = '1.8.0'
2 +
__version__ = '1.8.1'
Original file line number Diff line number Diff line change
@@ -423,7 +423,7 @@ def _browser_screenshot_session(
423 423
should_take_screenshot = (
424 424
hasattr(value, '__splinter_browser__') and
425 425
splinter_make_screenshot_on_failure and
426 -
request.node.splinter_failure
426 +
getattr(request.node, 'splinter_failure', True)
427 427
)
428 428 429 429
if should_take_screenshot:
@@ -505,7 +505,7 @@ def prepare_browser(request, parent, retry_count=3):
505 505 506 506
if request.scope == 'function':
507 507
def _take_screenshot_on_failure():
508 -
if splinter_make_screenshot_on_failure and request.node.splinter_failure:
508 +
if splinter_make_screenshot_on_failure and getattr(request.node, 'splinter_failure', True):
509 509
_take_screenshot(
510 510
request=request,
511 511
fixture_name=parent.__name__,
@@ -559,7 +559,7 @@ def pytest_runtest_makereport(item, call):
559 559
"""Assign the report to the item for futher usage."""
560 560
outcome = yield
561 561
rep = outcome.get_result()
562 -
if rep.outcome != 'passed':
562 +
if rep.outcome == 'failed':
563 563
item.splinter_failure = rep
564 564
else:
565 565
item.splinter_failure = None
You can’t perform that action at this time.
RetroSearch is an open source project built by @garambo | Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4