RetroSearch Browse

Home - News ( United States | United Kingdom | Italy | Germany ) - Football scores

Showing content from https://github.com/pmd/pmd/issues/4722 below:

[apex] New Parser - parsing errors and rule differences · Issue #4722 · pmd/pmd · GitHub

Affects PMD Version:

Branch experimental-apex-parser

Part of #3766

Description:

Collection of parser bugs and rule differences, that need to be investigated.

✅ Errors:
- Parse exception: Couldn't parse the source - there is not root node - Syntax Error??
  - https://github.com/SalesforceLabs/Schedul-o-matic-9000/blob/6b1229ba43b38931fbbab5924bc9b9611d19a786/force-app/main/default/classes/Dao.cls
  - https://github.com/SalesforceLabs/Schedul-o-matic-9000/blob/6b1229ba43b38931fbbab5924bc9b9611d19a786/force-app/main/default/classes/Dao_Test.cls
- Unhelpful parse exception message - just "Couldn't parse the source - there is not root node - Syntax Error??". Ideally, we would output here something like "at x:y, expect z, but found x". Note, that these two files explicitly contain syntax errors
  - https://github.com/nawforce/apex-link/blob/v2.3.0/samples/synthetic/sfdx-ns-test/force-app/main/default/classes/SingleError.cls
  - https://github.com/nawforce/apex-link/blob/v2.3.0/samples/synthetic/sfdx-ns-test/force-app/main/default/classes/DoubleError.cls
- Fixed by Fix multithreading issues and provide parse exceptions google/summit-ast#45
✅ Errors while executing rules
- AvoidNonExistentAnnotationsRule
  - https://github.com/apex-enterprise-patterns/fflib-apex-common/blob/7e0891efb86d23de62811af56d87d0959082a322/sfdx-source/apex-common/main/classes/fflib_QueryFactory.cls
  - https://github.com/apex-enterprise-patterns/fflib-apex-common/blob/7e0891efb86d23de62811af56d87d0959082a322/sfdx-source/apex-common/main/classes/fflib_SecurityUtils.cls
  - ➡️ Caused by the fact, that experimental parser doesn't generate a synthetic modifiers list node for enum values - and that's correct. Enum values can't have modifiers like "public", "static", or "final" - these are implicit.

Stacktrace 1

org.apache.commons.lang3.exception.ContextedRuntimeException: java.lang.NullPointerException
Exception Context:
	[1:Rule applied on node=ApexFile]
---------------------------------
	at net.sourceforge.pmd.util.AssertionUtil.contexted(AssertionUtil.java:232)
	at net.sourceforge.pmd.lang.rule.internal.RuleApplicator.applyOnIndex(RuleApplicator.java:77)
	at net.sourceforge.pmd.lang.rule.internal.RuleApplicator.apply(RuleApplicator.java:55)
	at net.sourceforge.pmd.RuleSets.apply(RuleSets.java:158)
	at net.sourceforge.pmd.lang.impl.PmdRunnable.processSource(PmdRunnable.java:140)
	at net.sourceforge.pmd.lang.impl.PmdRunnable.run(PmdRunnable.java:80)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: java.lang.NullPointerException
	at net.sourceforge.pmd.lang.apex.rule.errorprone.AvoidNonExistentAnnotationsRule.checkForNonExistentAnnotation(AvoidNonExistentAnnotationsRule.java:62)
	at net.sourceforge.pmd.lang.apex.rule.errorprone.AvoidNonExistentAnnotationsRule.visit(AvoidNonExistentAnnotationsRule.java:58)
	at net.sourceforge.pmd.lang.apex.ast.ASTField.acceptApexVisitor(ASTField.java:42)
	at net.sourceforge.pmd.lang.apex.ast.AbstractApexNode.acceptVisitor(AbstractApexNode.java:127)
	at net.sourceforge.pmd.lang.apex.ast.ApexParserVisitor.visitNode(ApexParserVisitor.java:17)
	at net.sourceforge.pmd.lang.apex.ast.ApexParserVisitor.visit(ApexParserVisitor.java:24)
	at net.sourceforge.pmd.lang.apex.ast.ApexParserVisitor.visitApexNode(ApexParserVisitor.java:29)
	at net.sourceforge.pmd.lang.apex.ast.ApexVisitor.visit(ApexVisitor.java:352)
	at net.sourceforge.pmd.lang.apex.rule.errorprone.AvoidNonExistentAnnotationsRule.visit(AvoidNonExistentAnnotationsRule.java:42)
	at net.sourceforge.pmd.lang.apex.ast.ASTUserEnum.acceptApexVisitor(ASTUserEnum.java:18)
	at net.sourceforge.pmd.lang.apex.ast.AbstractApexNode.acceptVisitor(AbstractApexNode.java:127)
	at net.sourceforge.pmd.lang.apex.ast.ApexParserVisitor.visitNode(ApexParserVisitor.java:17)
	at net.sourceforge.pmd.lang.apex.ast.ApexParserVisitor.visit(ApexParserVisitor.java:24)
	at net.sourceforge.pmd.lang.apex.ast.ApexParserVisitor.visitApexNode(ApexParserVisitor.java:29)
	at net.sourceforge.pmd.lang.apex.ast.ApexVisitor.visit(ApexVisitor.java:344)
	at net.sourceforge.pmd.lang.apex.rule.errorprone.AvoidNonExistentAnnotationsRule.visit(AvoidNonExistentAnnotationsRule.java:30)
	at net.sourceforge.pmd.lang.apex.ast.ASTUserClass.acceptApexVisitor(ASTUserClass.java:21)
	at net.sourceforge.pmd.lang.apex.ast.AbstractApexNode.acceptVisitor(AbstractApexNode.java:127)
	at net.sourceforge.pmd.lang.apex.ast.ApexParserVisitor.visitNode(ApexParserVisitor.java:17)
	at net.sourceforge.pmd.lang.apex.ast.ApexVisitor.visit(ApexVisitor.java:20)
	at net.sourceforge.pmd.lang.apex.ast.ASTApexFile.acceptApexVisitor(ASTApexFile.java:61)
	at net.sourceforge.pmd.lang.apex.ast.AbstractApexNode.acceptVisitor(AbstractApexNode.java:127)
	at net.sourceforge.pmd.lang.apex.rule.AbstractApexRule.apply(AbstractApexRule.java:17)
	at net.sourceforge.pmd.lang.rule.AbstractDelegateRule.apply(AbstractDelegateRule.java:232)
	at net.sourceforge.pmd.lang.rule.internal.RuleApplicator.applyOnIndex(RuleApplicator.java:75)
	... 9 more

Stacktrace 2

org.apache.commons.lang3.exception.ContextedRuntimeException: java.lang.NullPointerException
Exception Context:
	[1:Rule applied on node=ApexFile]
---------------------------------
	at net.sourceforge.pmd.util.AssertionUtil.contexted(AssertionUtil.java:232)
	at net.sourceforge.pmd.lang.rule.internal.RuleApplicator.applyOnIndex(RuleApplicator.java:77)
	at net.sourceforge.pmd.lang.rule.internal.RuleApplicator.apply(RuleApplicator.java:55)
	at net.sourceforge.pmd.RuleSets.apply(RuleSets.java:158)
	at net.sourceforge.pmd.lang.impl.PmdRunnable.processSource(PmdRunnable.java:140)
	at net.sourceforge.pmd.lang.impl.PmdRunnable.run(PmdRunnable.java:80)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: java.lang.NullPointerException
	at net.sourceforge.pmd.lang.apex.rule.errorprone.AvoidNonExistentAnnotationsRule.checkForNonExistentAnnotation(AvoidNonExistentAnnotationsRule.java:62)
	at net.sourceforge.pmd.lang.apex.rule.errorprone.AvoidNonExistentAnnotationsRule.visit(AvoidNonExistentAnnotationsRule.java:58)
	at net.sourceforge.pmd.lang.apex.ast.ASTField.acceptApexVisitor(ASTField.java:42)
	at net.sourceforge.pmd.lang.apex.ast.AbstractApexNode.acceptVisitor(AbstractApexNode.java:127)
	at net.sourceforge.pmd.lang.apex.ast.ApexParserVisitor.visitNode(ApexParserVisitor.java:17)
	at net.sourceforge.pmd.lang.apex.ast.ApexParserVisitor.visit(ApexParserVisitor.java:24)
	at net.sourceforge.pmd.lang.apex.ast.ApexParserVisitor.visitApexNode(ApexParserVisitor.java:29)
	at net.sourceforge.pmd.lang.apex.ast.ApexVisitor.visit(ApexVisitor.java:352)
	at net.sourceforge.pmd.lang.apex.rule.errorprone.AvoidNonExistentAnnotationsRule.visit(AvoidNonExistentAnnotationsRule.java:42)
	at net.sourceforge.pmd.lang.apex.ast.ASTUserEnum.acceptApexVisitor(ASTUserEnum.java:18)
	at net.sourceforge.pmd.lang.apex.ast.AbstractApexNode.acceptVisitor(AbstractApexNode.java:127)
	at net.sourceforge.pmd.lang.apex.ast.ApexParserVisitor.visitNode(ApexParserVisitor.java:17)
	at net.sourceforge.pmd.lang.apex.ast.ApexParserVisitor.visit(ApexParserVisitor.java:24)
	at net.sourceforge.pmd.lang.apex.ast.ApexParserVisitor.visitApexNode(ApexParserVisitor.java:29)
	at net.sourceforge.pmd.lang.apex.ast.ApexVisitor.visit(ApexVisitor.java:344)
	at net.sourceforge.pmd.lang.apex.rule.errorprone.AvoidNonExistentAnnotationsRule.visit(AvoidNonExistentAnnotationsRule.java:30)
	at net.sourceforge.pmd.lang.apex.ast.ASTUserClass.acceptApexVisitor(ASTUserClass.java:21)
	at net.sourceforge.pmd.lang.apex.ast.AbstractApexNode.acceptVisitor(AbstractApexNode.java:127)
	at net.sourceforge.pmd.lang.apex.ast.ApexParserVisitor.visitNode(ApexParserVisitor.java:17)
	at net.sourceforge.pmd.lang.apex.ast.ApexVisitor.visit(ApexVisitor.java:20)
	at net.sourceforge.pmd.lang.apex.ast.ASTApexFile.acceptApexVisitor(ASTApexFile.java:61)
	at net.sourceforge.pmd.lang.apex.ast.AbstractApexNode.acceptVisitor(AbstractApexNode.java:127)
	at net.sourceforge.pmd.lang.apex.rule.AbstractApexRule.apply(AbstractApexRule.java:17)
	at net.sourceforge.pmd.lang.rule.AbstractDelegateRule.apply(AbstractDelegateRule.java:232)
	at net.sourceforge.pmd.lang.rule.internal.RuleApplicator.applyOnIndex(RuleApplicator.java:75)
	... 9 more

Rule Changes
- ✅ EmptyStatementBlock - now finds empty catch blocks. Is this correct behavior or a false positive?
  - https://github.com/SalesforceLabs/Schedul-o-matic-9000/tree/6b1229ba43b38931fbbab5924bc9b9611d19a786/force-app/main/default/classes/Scheduler.cls#L124
  - https://github.com/apex-enterprise-patterns/fflib-apex-common/tree/7e0891efb86d23de62811af56d87d0959082a322/sfdx-source/apex-common/test/classes/fflib_QueryFactoryTest.cls#L270
  - ➡️ This is a new false positive. Empty catch blocks are the duty of the rule "EmptyCatchBlock" and should not be reported by EmptyStatementBlock
- ✅ AvoidDeeplyNestedIfs - now finds more cases. Is this correct behavior or a false positive?
  - https://github.com/SalesforceLabs/Schedul-o-matic-9000/tree/6b1229ba43b38931fbbab5924bc9b9611d19a786/force-app/main/default/classes/Scheduler.cls#L305
  - https://github.com/SalesforceLabs/Schedul-o-matic-9000/tree/6b1229ba43b38931fbbab5924bc9b9611d19a786/force-app/main/default/classes/Scheduler.cls#L336
  - ➡️ This is actually now correct behavior: Previously two AvoidDeeplyNestedIfStmts were reported on the same line, because the else-if block as incorrect line numbers in the jorje parser variant of PMD. The line numbers are now correct with the experimental parser.
- ✅ ApexDoc - doesn't find missing apexdoc comment - potential introduced false negative
- ✅ New ApexDoc violation - Missing ApexDoc @description - for static init block. Is this correct or is this a false positive?
  - https://github.com/apex-enterprise-patterns/fflib-apex-common/tree/7e0891efb86d23de62811af56d87d0959082a322/sfdx-source/apex-common/main/classes/fflib_SObjectDomain.cls#L107
  - ➡️ The formal comments were not always added to the correct nodes. In this case, a formal comment on a field was added to the static block (which is in the AST actually the method <clinit>). In the Jorje variant, we didn't support formal comments for fields in AST, now we do. So, this is a overall improvement. Note: The rule ApexDoc doesn't consider fields.
- ✅ FieldDeclarationShouldBeAtStart is reporting wrong line number (it reports the initialization instead of the declaration)
  - https://github.com/apex-enterprise-patterns/fflib-apex-common/tree/7e0891efb86d23de62811af56d87d0959082a322/sfdx-source/apex-common/test/classes/fflib_ApplicationTest.cls#L476 - line 475 should be reported instead
  - https://github.com/apex-enterprise-patterns/fflib-apex-common/tree/7e0891efb86d23de62811af56d87d0959082a322/sfdx-source/apex-common/test/classes/fflib_ApplicationTest.cls#L483 - line 482 should be reported instead
  - https://github.com/apex-enterprise-patterns/fflib-apex-common/tree/7e0891efb86d23de62811af56d87d0959082a322/sfdx-source/apex-common/test/classes/fflib_ApplicationTest.cls#L491 - line 490 should be reported instead
  - https://github.com/apex-enterprise-patterns/fflib-apex-common/tree/7e0891efb86d23de62811af56d87d0959082a322/sfdx-source/apex-common/test/classes/fflib_ApplicationTest.cls#L498 - line 497 should be reported instead
  - ➡️ this is corrected by reporting on FieldDeclaration nodes instead of Field nodes.
- ✅ FieldNamingConventions is reporting wrong line number, similar to FieldDeclarationShouldBeAtStart
  - https://github.com/apex-enterprise-patterns/fflib-apex-common/tree/7e0891efb86d23de62811af56d87d0959082a322/sfdx-source/apex-common/test/classes/fflib_ApplicationTest.cls#L476 - line 475 should be reported instead
  - https://github.com/apex-enterprise-patterns/fflib-apex-common/tree/7e0891efb86d23de62811af56d87d0959082a322/sfdx-source/apex-common/test/classes/fflib_ApplicationTest.cls#L483 - line 482 should be reported instead
  - https://github.com/apex-enterprise-patterns/fflib-apex-common/tree/7e0891efb86d23de62811af56d87d0959082a322/sfdx-source/apex-common/test/classes/fflib_ApplicationTest.cls#L491 - line 490 should be reported instead
  - https://github.com/apex-enterprise-patterns/fflib-apex-common/tree/7e0891efb86d23de62811af56d87d0959082a322/sfdx-source/apex-common/test/classes/fflib_ApplicationTest.cls#L498 - line 497 should be reported instead
  - https://github.com/apex-enterprise-patterns/fflib-apex-common/tree/7e0891efb86d23de62811af56d87d0959082a322/sfdx-source/apex-common/test/classes/fflib_SObjectUnitOfWorkTest.cls#L32 - line 31 should be reported instead
  - ➡️ this is corrected by reporting on FieldDeclaration nodes instead of Field nodes.
- ✅ CognitiveComplexity / CyclomaticComplexity - message is different
  - when reporting the method descriptor, generic types are maybe missing? or use a different casing (sobject vs. SObject)
  - https://github.com/apex-enterprise-patterns/fflib-apex-common/tree/7e0891efb86d23de62811af56d87d0959082a322/sfdx-source/apex-common/main/classes/fflib_SObjectDomain.cls#L402
  - see also Violation messages should be escaped for html pmd-regression-tester#121
  - ➡️ The difference is, that now an additional space is added when there are multiple generic type params, e.g. instead of Map<Id,SObject> now it is Map<Id, SObject>. I like it this way better, so we keep it and expect slight changes in the violation messages.

RetroSearch is an open source project built by @garambo | Open a GitHub Issue

Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo

HTML: 3.2 | Encoding: UTF-8 | Version: 0.7.4