Showing content from https://github.com/pmd/pmd/issues/3128 below:
[java] New rule UnnecessaryImport, deprecate DuplicateImports, ImportFromSamePackage, UnusedImports, DontImportJavaLang · Issue #3128 · pmd/pmd · GitHub
Is your feature request related to a problem? Please describe.
We have the rules DuplicateImports, UnusedImports, and ImportFromSamePackage
- Duplicate imports are useless, so I think the first rule should naturally be subsumed by the second.
- The DuplicateImports rule tries to figure out whether the imports overlap or whether they maybe are necessary because of some ambiguity. This is awkward and should already be better checked by UnusedImports (because it considers eg comments). There's really no need to write that logic twice. The same argument applies to ImportFromSamePackage, although it doesn't even try to handle these conflicts.
- The rules are in 3 different categories (codestyle, bestpractices, errorprone), which is confusing. I don't see a reason to use one and not the other.
Describe the solution you'd like Deprecate DuplicateImports and ImportFromSamePackage in favor of UnusedImports.
Deprecate all 3 existing rules and add a new rule "UnnecessaryImport" which replaces these 3.
Additional context Updating DuplicateImports and UnusedImports to pmd 7 is not going to be trivial, which is why removing one of those would be nice. I don't even know why ImportFromSamePackage is separate.
RetroSearch is an open source project built by @garambo
| Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4