Home - News ( United States | United Kingdom | Italy | Germany ) - Football scores

Showing content from https://github.com/pmd/pmd/issues/2764 below:

[java] CloseResourceRule does not recognize multiple assignment done to resource · Issue #2764 · pmd/pmd · GitHub

Affects PMD Version: PMD ??? (1.2.2 is an invalid version...)

Rule: CloseResourceRule

Description:
The CloseResourceRule does not identify in case the resource variable got re assigned by developer

Code Sample demonstrating the issue:

public class Bar {
    public void withSQL() {
        Connection c = pool.getConnection();
        try {
            // do stuff
            // oops, should not have assgined the connection again to the variable 
            c = pool.getConnection();
        } catch (SQLException ex) {
           // handle exception
        } finally {
            // oops, one connection leak'!
            c.close();
        }
    }  
}

Expected outcome:

• It is expected that PMD reports a violation of resource re assignment. The other rules DataflowAnomalyAnalysisRule and java/bestpractices/UnusedAssignment is not effective also to detect this .
• Is PMD missing to report a violation, where there should be one? -> false-negative

Running PMD through: [CLI | Ant | Maven | Gradle | Designer | Other]

RetroSearch is an open source project built by @garambo | Open a GitHub Issue

Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo

HTML: 3.2 | Encoding: UTF-8 | Version: 0.7.4