A RetroSearch Logo

Home - News ( United States | United Kingdom | Italy | Germany ) - Football scores

Search Query:

Showing content from https://github.com/pmd/pmd/issues/1880 below:

[java] CommentDefaultAccessModifier should be configurable for top-level classes · Issue #1880 · pmd/pmd · GitHub

Rule: CommentDefaultAccessModifier

The code quality metric that this rule in its original state helped to improve is the scope of visibility.

Forgetting the access modifier of a potentially private or protected nested elements INCREASES the visibility to package visibility. As a result, other developers might access internal state of a class.

Completely different story with top level elements: The only possible access modifier for top level elements is public! So forgetting the access modifier of a top level elements does no harm in terms of code quality, at least not in respect to above metric.

The change calls for a lot of additional /* package */ comments without any reward in terms of code quality. Please revert or create a new rule for the changed behavior.

Originally posted by @matthiaskraaz in #1793 (comment)


RetroSearch is an open source project built by @garambo | Open a GitHub Issue

Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo

HTML: 3.2 | Encoding: UTF-8 | Version: 0.7.4