Home - News ( United States | United Kingdom | Italy | Germany ) - Football scores

Showing content from https://github.com/mariusmuntean/ChartJs.Blazor/issues/95 below:

[DISCUSSION] Referencing chart.js through our library · Issue #95 · mariusmuntean/ChartJs.Blazor · GitHub

In the README and in our samples, we reference chart.js and moment.js through our library with the _content directory added by blazor. It's included in the sources of this library and is automatically integrated into the client-side root of applications that consume this library.
But why?

We can write what version of chart.js we currently support and we can let the consumer chose themselfs how to include the chart.js. We can also let them chose if they want the minified version or not. Why should we include the JavaScript-file of chart.js in our library as well, doesn't it just bloat the nuget size?

It would be a breaking change to remove it but here's why I think it would make sense.

• Smaller nuget-size
• We can keep the type files for TypeScript, no need to change that
• When we migrate to chart.js 3.0, we'll have trouble with the time-adapters anyway. You don't need moment.js anymore, you can use any time-adapter you want. So which one would we have in our library?
• More flexible for the consumer (minified, version, cdn)
• Only the script tag in the _Host.cshtml or index.html would change in the consumers application

• Breaking change, consumers need to change some code
• We need to clearly document what version we support and be aware of it (this is actually a benefit IMO but it requires additional work)

If possible, I would like to hear some opinions on this before we decide anything. Can anyone tell us some good arguments for keeping it in? Or do you agree with me that it should be excluded from the project and just be documented well?

cc @mariusmuntean

RetroSearch is an open source project built by @garambo | Open a GitHub Issue

Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo

HTML: 3.2 | Encoding: UTF-8 | Version: 0.7.4