Following #62 , I have implemented Mapbox rebased on reverse-geocoding
branch.
See the checklist below:
Datadata-raw/api_reference.R
updatedR/data.R
sandbox/query_debugging/mapbox_test.R
sandbox/reverse_queries/mapbox_reverse.R
R/utils.R
- Utils added for MapboxR/query_factory.R
updatedR/geo_methods.R
updatedR/geo.R
updatedR/reverse_geo.R
updatedtestthat
test addedregression_testing.Rmd
Some Notes not related with the PR itself:
#> * checking CRAN incoming feasibility ... NOTE #> Version contains large components (1.0.2.9000)
And this:
Found the following (possibly) invalid URLs:
URL: https://osm.org/copyright (moved to https://www.openstreetmap.org/copyright)
From: README.md
Status: 200
Message: OK
I checked and that url is generated by the response of the reverse_geocode
on the README (see table on https://github.com/dieghernan/tidygeocoder/blob/master/README.md#usage), so not related with the package.
There are two additional topics about which I would like to gather your feedback,
Integrate Github ActionGithub Actions can run R CMD CHECK
on a package repo over different platforms and R versions. I use this on my packages, you can see more on https://github.com/r-lib/actions/blob/master/examples/README.md
I included my version while developing. This Github Action would run regularly once a week and after every commit/PR on branchs master
or main
,, checks are performed on devel, release, oldrel on Linux, macOS and Windows (as CRAN):
https://github.com/dieghernan/tidygeocoder/actions/runs/620783144
Before removing it I just wanted to check if you would like to integrate this on your repo.
About batch geocodingThis is possible on Mapbox but under the commercial endpoint mapbox.places-permanent
https://docs.mapbox.com/api/search/geocoding/#batch-geocoding
I do not have that kind of access, so I didn't include it. I asked Mapbox Team if there is any way I can get a limited dev account for checking, I would let you know.
What I can do if this is strictly required is to include the capability using a mock answer of the API as example (see here), but I won't be able to check it if I don't get a permanent API key (maybe someone with that kind of key could help, @maxachis¿?).
Regards
RetroSearch is an open source project built by @garambo | Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4