RetroSearch Browse

Home - News ( United States | United Kingdom | Italy | Germany ) - Football scores

Showing content from https://github.com/gorhill/uBlock/commit/bcf5ac1feec0019663a3ad564caeb1c67679791e below:

Add advanced setting to control logger popup type · gorhill/uBlock@bcf5ac1 · GitHub

File tree Expand file treeCollapse file tree 3 files changed

+10

-9

lines changed

Filter options

Expand file treeCollapse file tree 3 files changed

+10

-9

lines changed Original file line number Diff line number Diff line change


 @@ -387,11 +387,11 @@ vAPI.Tabs = class {

387 387 388 388


 // Properties of the details object:

389 389


 // - url: 'URL', => the address that will be opened

390

-
 // - index: -1, => undefined: end of the list, -1: following tab, or

391

-
 // after index

392

-
 // - active: false, => opens the tab in background - true and undefined:

393

-
 // foreground

394

-
 // - popup: true  => open in a new window

390

+
 // - index: -1, => undefined: end of the list, -1: following tab,

391

+
 // or after index

392

+
 // - active: false, => opens the tab... in background: true,

393

+
 // foreground: undefined

394

+
 // - popup: 'popup' => open in a new window

395 395 396 396


 create(url, details) {

397 397


 if ( details.active === undefined ) {


 @@ -443,10 +443,10 @@ vAPI.Tabs = class {

443 443


 // For some reasons, some platforms do not honor the left,top

444 444


 // position when specified. I found that further calling

445 445


 // windows.update again with the same position _may_ help.

446

-
 if ( details.popup === true && browser.windows instanceof Object ) {

446

+
 if ( details.popup !== undefined && browser.windows instanceof Object ) {

447 447


 const createDetails = {

448 448


 url: details.url,

449

-
 type: 'popup',

449

+
 type: details.popup,

450 450

};

451 451


 if ( details.box instanceof Object ) {

452 452


 Object.assign(createDetails, details.box);

Original file line number Diff line number Diff line change


 @@ -52,6 +52,7 @@ const µBlock = (function() { // jshint ignore:line

52 52


 disableWebAssembly: false,

53 53


 ignoreRedirectFilters: false,

54 54


 ignoreScriptInjectFilters: false,

55

+
 loggerPopupType: 'popup',

55 56


 manualUpdateAssetFetchPeriod: 500,

56 57


 popupFontSize: 'unset',

57 58


 requestJournalProcessPeriod: 1000,

Original file line number Diff line number Diff line change


 @@ -386,8 +386,8 @@

386 386


 !this.userSettings.alwaysDetachLogger

387 387

);

388 388

389

-
 details.popup = this.userSettings.alwaysDetachLogger;

390

-
 if ( details.popup ) {

389

+
 if ( this.userSettings.alwaysDetachLogger ) {

390

+
  details.popup = this.hiddenSettings.loggerPopupType;

391 391


 const url = new URL(vAPI.getURL(details.url));

392 392


 url.searchParams.set('popup', '1');

393 393


 details.url = url.href;

You can’t perform that action at this time.

RetroSearch is an open source project built by @garambo | Open a GitHub Issue

Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo

HTML: 3.2 | Encoding: UTF-8 | Version: 0.7.4