+11
-2
lines changedFilter options
+11
-2
lines changed Original file line number Diff line number Diff line change
@@ -103,7 +103,13 @@ def start_command(cmd, cwd=None, shell=False, add_env=None,
103 103
if add_env is not None:
104 104
env = os.environ.copy()
105 105
env.update(add_env)
106 -
cmd = [encode(c) for c in cmd]
106 +
if sys.platform == 'win32':
107 +
# Python on windows always goes through list2cmdline() internally inside
108 +
# of subprocess.py so we must provide unicode strings here otherwise
109 +
# Python3 breaks when bytes are provided.
110 +
cmd = [decode(c) for c in cmd]
111 +
else:
112 +
cmd = [encode(c) for c in cmd]
107 113
return subprocess.Popen(cmd, bufsize=1, stdin=stdin, stdout=stdout,
108 114
stderr=stderr, cwd=cwd, shell=shell, env=env,
109 115
universal_newlines=universal_newlines)
@@ -163,7 +163,6 @@ def execute(command,
163 163
extra = {}
164 164
if sys.platform == 'win32':
165 165
command = map(replace_carot, command)
166 -
extra['shell'] = True
167 166 168 167
# Start the process
169 168
# Guard against thread-unsafe .git/index.lock files
@@ -30,6 +30,10 @@ Fixes
30 30 31 31
https://github.com/git-cola/git-cola/issues/242
32 32 33 +
* Better support for Python3 on Windows
34 + 35 +
https://github.com/git-cola/git-cola/issues/246
36 + 33 37
git-cola v2.0.1
34 38
===============
35 39
Usability, bells and whistles
You can’t perform that action at this time.
RetroSearch is an open source project built by @garambo | Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4