The code at:
auto format(view_ref& value, FormatContext& ctx) const -> decltype(ctx.out()) { auto it = std::forward<view_ref>(value).begin; auto out = ctx.out(); if (it == value.end) return out; out = value_formatter_.format(*it, ctx);Does a
auto it = std::forward<view_ref>(value).begin;
and later accesses value.end and value.sep.
In the case the iterator is not copy constructible then the view_ref is an rvalue-reference:
using view_ref = conditional_t<std::is_copy_constructible<It>::value,
const join_view<It, Sentinel, Char>&,
join_view<It, Sentinel, Char>&&>;
which effectively turns the forward<> into a move.
clang-tidy warns on the accesses of end and sep as they are accesses on a moved-from object.
I'm not sure that this is really a problem in practice but it seems like something that should be avoided. I can't see an easy way to do so though. I'm not sure we can cast just the iterator easily? Taking a copy of sep works but for the same reasons as above we can't copy end out without a move either.
RetroSearch is an open source project built by @garambo | Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4