A RetroSearch Logo

Home - News ( United States | United Kingdom | Italy | Germany ) - Football scores

Search Query:

Showing content from https://github.com/Suchiman/SerilogAnalyzer/issues/23 below:

String concat does not handle escaped characters properly · Issue #23 · Suchiman/SerilogAnalyzer · GitHub

Thanks for the addition of the string concatenation refactoring! I really appreciate the effort.

The string concatenation to message template refactor doesn't seem to work when there are newlines or other escaped characters in the text. I think think might be because of L67 of ConvertToMessageTemplateCodeRefactoringProvider.StringConcat.cs

sb.Append(literal.Token.ValueText);

because I think it is then evaluated here:

format = (InterpolatedStringExpressionSyntax)SyntaxFactory.ParseExpression(sb.ToString());

and those are treated as newlines in the code vs the escape value string or something...

e.g. this:

_log4.Debug("RegisterRecorder called with the following parameters: \n FDQN: '" + fqdn + "' \n Guid: '" + id + "' \n Modalities: '" + modalitiesWithCapacity + "' \n URI: '" + uri + "' \n supportedModes: '" + supportedMethods + "' ");

transforms to this:

_log4.Debug("RegisterRecorder called with the following parameters: ");

I'm not really sure how to debug this, but if I can help let me know.


RetroSearch is an open source project built by @garambo | Open a GitHub Issue

Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo

HTML: 3.2 | Encoding: UTF-8 | Version: 0.7.4