TypeScript Version: 2.0.0-beta
@zhengbli The following commit appears to have broken the getSourceFilePathInNewDir implementation in certain circumstances:
The use of getCanonicalFileName breaks the implementation if the common directory is a parent of the current directory.
For example, with these files:
C:/Users/Nicholas/example/a/a.ts
C:/Users/Nicholas/example/b/b.ts
The common directory is C:/Users/Nicholas/example.
If the current directory is C:/Users/Nicholas/example/b, for the a.ts source file:
cannonical source = ../a/a.ts
cannonical common = ..
So isSourceFileInCommonSourceDirectory will be true.
However, for the b.ts source file:
cannonical source = b.ts
cannonical common = ..
So isSourceFileInCommonSourceDirectory will be false - which will result in the absolute path to the source file - C:/Users/Nicholas/example/b/b.ts - being returned.
Specifically, this change to the implementation breaks my tsify-based builds.
RetroSearch is an open source project built by @garambo | Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4