Proposed by: @norberttech
Date: 2025-01-09
Flow is a framework, and as all frameworks, it should provide extension points for developers to hook into the framework and extend its functionality.
How to find an extension point?
Easy, look for interfaces! For example take a look at \Flow\ETL\Cache which is an interface with few implementations. Thanks to the interface, you can easily create your own implementation and use it in the framework.
Most of the extension points exposed through \Flow\ETL\Config where you can replace a default implementations of various interfaces with those that better fit your needs.
Those extension points are there by design and should follow the backward compatibility policy.
Are there any other extension points that we should consider?
Yes... Unfortunately, each class that is not marked final and that is being somehow injected into the DataFrame must be considered as an extension point.
Why? Because nothing prevents developers from extending those classes and injecting their custom version into the DataFrame.
Those extension points can't be covered by our backward compatibility policy.
#DecisionClosed by default
All classes should be marked as final and whenever we need to expose an extension point, we should do it through an interface.
Always possible to open later
In a justifiable cases, we can expose extension points through abstract classes or simply allowing people to extend the class. Those must always be approved by one of the core contributors.
No guarantee and support for workarounds
Developers can still use reflections or dedicated tools to "unfinalize" Flow classes, but we do not guarantee backward compatibility for those cases and everyone should do it at their own risk. As a Flow PHP maintainers, we also reserve the right to not provide any help or support for those cases.
#Pros & Consfinal in tests (which is a good thing, users shouldn’t mock Flow classes in their test suites)Alternatively we could take similar approach to Symfony and mark classes as final when it makes sense but this approach is too easy to get abused.
Plus, changing non-final class into a final one is much bigger BC break then the other way around.
#Links and References (optional)RetroSearch is an open source project built by @garambo | Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4