Hi, On 12/31/06, Ronald S. Bultje <rbultje at ronald.bitfreak.net> wrote: > Hi Michael, > > On Fri, 2006-12-29, Michael Niedermayer wrote: > > On Wed, Dec 27, 2006 at 08:11:39PM -0500, Ronald S. Bultje wrote: > > > I don't mind if file_size is not available for a while (until whenever > > > is the next time that ABI is broken) on such streams, but it should be, > > > eventually. Adding file_size really is the right thing to do, imo. > > > > if the patch which adds file_size + a function pointer for ByteIOContext > > is small then ive no objections if its large i do have objections ... > > OK, I've attached a patch below which does just that. > > As for the small second patch, I noticed misbehaviour in url_fseek() > when seeking fails. The return value of the seek function in my http. > seek implementation and from lseek() in file.c (only protocol > implementing seek so far) is -1 on error, not -EPIPE (the return value > in url_seek() if no seek function pointer is set), hence the bugfix. > Should be a no-brainer. Applied Guillaume
RetroSearch is an open source project built by @garambo | Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4