Hi On Mon, Jan 29, 2007 at 11:46:00AM +0000, Ian Caulfield wrote: [...] > >I'm not sure about the yuvtorgb code - I lifted this from dvbsubdec.c, but > >I > >> reckon it should probably live somewhere else, though I couldn't decide > >> where. > > > >well choose a filename you like and put it there, copy and paste is not ok > >ideally the yuv2rgb code from libswscale/ should be used / or the code > >should > >be moved into libswscale/ but thats not so important and can be done later > > > The defines seem to have been copied from imgconvert.c - should I move the > yuv->rgb function there? Which would be an appropriate header to insert the > declaration into? i dont know, not avcodec.h maybe just add a new .c + .h file for this [...] > > and guess_palette() could then do the yuv->rgb which is IMHO cleaner then > >your code where the 2bit palette is "converted" in guess_palette() while > >the 8bit one is handled while it is read > > > I'm not keen on this - in the 2bit case, the "palette" in the bitstream is > actually a mapping of the four colours in the subtitle onto the external DVD > 16-color palette. Since we don't have access to this palette, we have to > guess our own. For 8-bit subtitles, an actual palette is embedded into the > bitstream, which we can then use. I could rename the guess_palette function > to guess_palette_2bit, and add an "extract_palette_8bit" function which > would do the colourspace conversion and merge in the alpha components? ok, do whatever you think is best, i just want clean,fast,readable and simple code [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB While the State exists there can be no freedom; when there is freedom there will be no State. -- Vladimir Lenin -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070130/84602a7d/attachment.pgp>
RetroSearch is an open source project built by @garambo | Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4