Hi On Mon, Jan 29, 2007 at 01:36:40PM +0100, Michel Bardiaux wrote: [...] > > > > > >>Note: it is quite likely this patch actually hides a bug in > >>avcodec_default_get_buffer that causes it to fail without returning > >> failure status. I am looking into that. > > > >yes i agree that avcodec_default_get_buffer is likly buggy > > The problem there seems to be simply that assert() is ignored: > > assert(INTERNAL_BUFFER_SIZE > s->internal_buffer_count); > > Is it OK to change that to av_log plus return(-1)? ok > > >to but either way the buffers must be released ... there also needs > >to be a release_buffer() in "decode_end" which is also missing in > >bmp.c > > Isnt that true of *every* codec? But I see png.c pnm.c having no every codec should release its buffers, its just 1 or 2 lines of code for each and it causes problems for user applications (xine at least ...) > decode_end. Should I add it there too? And would 8bps.c be a good example? i think so > > Anyway, I would rather schedule this after all the things I already have > going: the change of the bmp decoder to bytestream, and the bmp encoder, > and the FACT chunk, and the MSGSM codec. sure sure, do things in whichever order you prefer [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The worst form of inequality is to try to make unequal things equal. -- Aristotle -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070129/7b442472/attachment.pgp>
RetroSearch is an open source project built by @garambo | Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4