RetroSearch Browse

Mon Jan 29 16:21:33 CET 2007 · https://ffmpeg.org/pipermail/ffmpeg-devel/2007-January/028194.html

Hi,

On Thu, 2007-01-25 at 01:54 +0100, Michael Niedermayer wrote:
> Hi
> 
> On Thu, Jan 25, 2007 at 12:53:14AM +0000, M?ns Rullg?rd wrote:
> > Michael Niedermayer <michaelni at gmx.at> writes:
> > 
> > > Hi
> > >
> > > On Wed, Jan 24, 2007 at 04:39:40PM +0100, Panagiotis Issaris wrote:
> > >> Hi,
> > >> 
> > >> The attached patch adds the const specifier as needed in the snow.c
> > >> file. This to reduce the number of warnings.
> > >> 
> > >> With friendly regards,
> > >> Takis
> > >> -- 
> > >> vCard: http://www.issaris.org/pi.vcf
> > >> Public key: http://www.issaris.org/pi.key
> > >
> > >> diff --git a/libavcodec/dsputil.h b/libavcodec/dsputil.h
> > >> index 78109f7..1574267 100644
> > >> --- a/libavcodec/dsputil.h
> > >> +++ b/libavcodec/dsputil.h
> > >> @@ -388,7 +388,7 @@ typedef struct DSPContext {
> > >>      /* snow wavelet */
> > >>      void (*vertical_compose97i)(DWTELEM *b0, DWTELEM *b1, DWTELEM *b2, DWTELEM *b3, DWTELEM *b4, DWTELEM *b5, int width);
> > >>      void (*horizontal_compose97i)(DWTELEM *b, int width);
> > >> -    void (*inner_add_yblock)(uint8_t *obmc, const int obmc_stride, uint8_t * * block, int b_w, int b_h, int src_x, int src_y, int src_stride, slice_buffer * sb, int add, uint8_t * dst8);
> > >> +    void (*inner_add_yblock)(const uint8_t *obmc, const int obmc_stride, uint8_t * * block, int b_w, int b_h, int src_x, int src_y, int src_stride, slice_buffer * sb, int add, uint8_t * dst8);
> > >
> > > how does changing int obmc_stride to const supress a warning?
> > 
> > That one was already const.  The patch changes the uint8_t *obmc to
> > const, which might well make a difference.
> 
> ohh indeed i should look more carefull ...
> anyway changing obmc to const is ok

The previous patch reduced the number of warnings for the snow.c
compilation, but increased the number of warnings in other files,
leading to an identical number of warnings before and after the patch.

The attached updated patch globally reduces the number of warnings from
327 to 325.

 dsputil.h          |    2 +-
 i386/dsputil_mmx.c |    4 ++--
 i386/snowdsp_mmx.c |   12 ++++++------
 snow.c             |   18 +++++++++---------
 snow.h             |    2 +-
 5 files changed, 19 insertions(+), 19 deletions(-)

With friendly regards,
Takis
-- 
vCard: http://www.issaris.org/pi.vcf
Public key: http://www.issaris.org/pi.key
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pi-20070129T161524-ffmpeg-const.diff
Type: text/x-patch
Size: 9005 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070129/08535544/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070129/08535544/attachment.pgp>

Home - News ( United States | United Kingdom | Italy | Germany ) - Football scores

Showing content from https://ffmpeg.org/pipermail/ffmpeg-devel/2007-January/028194.html below:

[Ffmpeg-devel] [PATCH] Reduce warnings by adding const specifier snow.c