Michael Niedermayer wrote: > Hi > > On Tue, Jan 23, 2007 at 03:33:52PM +0100, Alex Beregszaszi wrote: >> > Hi, >> > >>> > > +#define read16(bits) bswap_16(get_bits(bits, 16)) >>> > > +#define read32(bits) bswap_32(get_bits_long(bits, 32)) >> > ... >>> > > +#define write16(bits, val) put_bits(bits, 16, bswap_16(val)) >>> > > +#define write32(bits, val) put_bits(bits, 32, bswap_32(val)) >> > >> > What about using bytestream.h or intreadwrite.h instead this? I dont see >> > its putting/reading non-8bit aligned data: > > no objections feel free to send a patch after this has been applied Here it is. > but note ill reject it if bmp.o becomes larger (speed is irrelevant, only > size and readability matters for this code) bmp.o is 20% smaller now. > i also suspect changing the #define to a static func() would be a good > idea ... Irrelevant now. Greetings, -- Michel Bardiaux R&D Director T +32 [0] 2 790 29 41 F +32 [0] 2 790 29 02 E mailto:mbardiaux at mediaxim.be Mediaxim NV/SA Vorstlaan 191 Boulevard du Souverain Brussel 1160 Bruxelles http://www.mediaxim.com/ -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: lavc_bmpdec_3.pat URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070129/9dc63c8d/attachment.txt>
RetroSearch is an open source project built by @garambo | Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4