> Hi > > On Sat, Jan 27, 2007 at 09:25:07PM +0100, Fran?ois Revol wrote: > > > > > > - return errno; > > > > > > + return av_error_from_errno(errno); > > > > > > > > > > hmm this should be a AVERROR_NOMEM i think? if so it should > > > > > be changed in a seperate commit before the other AVERROR stuff > > > > > > > > No idea, I didn't write that code. > > > > > > sure but the correctness of this affects the need and placement of some > > > function you add so your change depends on first having the above resolved > > > > So, should I commit this one first ? > > OTH I have nothing against using errno there, but the error won't be of much help to the caller anyway, he'd better know for sure it was ENOMEM. > > commit it, errno is wrong, it could even be 0 if lav* is used in a > multithreaded program Hmm if it's built as a single threaded lib linking to the globa errno yes... but that's very bad, and we use errno in several other places anyway. In BeOS things are threaded by default, much simpler :) Ok, commited. Fran?ois.
RetroSearch is an open source project built by @garambo | Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4