Michael Niedermayer wrote: > Hi > > On Wed, Jan 24, 2007 at 05:16:06PM -0200, ramiro at lisha.ufsc.br wrote: > >> Hello, >> >> The current inet_aton implementation in os_support.c returns valid even if >> a string (the hostname) has been passed. >> >> Fran?ois, does it work for you when passing a hostname instead of an IP >> address to FFmpeg? >> >> Does BeOS have the inet_addr function? If so we could use Michael Kohn's >> implementation of inet_aton as a wrapper around inet_addr. >> >> Attached patch takes inet_aton from uClibc (which is also LGPL). >> > > what problem does this patch solve? > > also the new code looks more complex then the old this is enough for > rejection unless you proof that this complexity is needed to solve the > problem > Much cleaner patch attached. I thought this would lead to returning non-zero on some hostnames, but according to RFC 1035, a hostname label can't start with a number, so it's ok. Fran?ois, is this ok for BeOS? (add->s_addr being returned as an int) -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: inet_aton.diff URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070128/d9ea3c0b/attachment.txt>
RetroSearch is an open source project built by @garambo | Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4