Aurelien Jacobs wrote: > On Wed, 24 Jan 2007 15:16:18 +0100 > Michel Bardiaux <mbardiaux at mediaxim.be> wrote: > >> M?ns Rullg?rd wrote: >>> Michael Niedermayer <michaelni at gmx.at> writes: >>> >>> [...] >>> >>>> better put the encoder into its own file >>> Yes, please. >> OK, I will. That implies moving the BMP_RLE4 etc to a bmp.h, and >> BMPContext. What should I do about the _init method? One for enc and one >> for dec, even if that duplicates the code? > > Idealy you could `svn mv bmp.c bmpdec.c` Plus some Makefile massage of course. > then create a new bmp.c file > containing common code for encoder and decoder (with proper declarations > in bmp.h). > But it may be overkill in this situation, and maybe duplicating this > 2 lines _init function is ok ? > > Aurel My thoughts exactly. Unfortunately Murphy & Finagle apply here: whatever choice I make (duplication, or move to a runt file) is likely to be flamed. So I'm stuck until Michael makes a ruling. HaND, -- Michel Bardiaux R&D Director T +32 [0] 2 790 29 41 F +32 [0] 2 790 29 02 E mailto:mbardiaux at mediaxim.be Mediaxim NV/SA Vorstlaan 191 Boulevard du Souverain Brussel 1160 Bruxelles http://www.mediaxim.com/
RetroSearch is an open source project built by @garambo | Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4