Aurelien Jacobs <aurel at gnuage.org> writes: > On Mon, 22 Jan 2007 00:21:42 +0000 > M?ns Rullg?rd <mru at inprovide.com> wrote: > >> Diego Biurrun <diego at biurrun.de> writes: >> >> > On Mon, Jan 22, 2007 at 12:52:15AM +0100, Aurelien Jacobs wrote: >> >> >> >> Here is a patch which further improve new Mans dependency tracking system. >> >> It moves dependency information from configure to allcodecs.c/allformats.c. >> >> Advantages are that it simplifies configure and that when you add a new >> >> codec, you don't need to mess with configure. Just add a new line in >> >> allcodecs.c and you're done. >> >> Opinions ? >> >> Can I commit this ? >> > >> > Putting that info in a comment sounds very fragile to me. This way >> > compilation might fail if somebody changes a comment ... >> >> I've never liked the idea of putting essential information in comments >> either. I've seen such things go horribly wrong. >> >> I wouldn't mind moving the dependency information to a separate file >> though, if people don't like the idea of having it embedded in the >> configure script. > > Adding a new file wouldn't be very nice. > My goal was to avoid having to edit one more file when adding a new > codec. IOW group related informations together. You anyway need to edit allcodecs.c, avcodec.h, and Makefile. A somewhat different approach would be to generate all these lists from a single source in a more suitable format. -- M?ns Rullg?rd mru at inprovide.com
RetroSearch is an open source project built by @garambo | Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4