RetroSearch Browse

Wed Jan 17 11:28:16 CET 2007 · https://ffmpeg.org/pipermail/ffmpeg-devel/2007-January/027524.html

Hi Takis,

On Wed, 2007-01-17 at 10:40 +0100, Panagiotis Issaris wrote:
> Hi,
> 
> Attached are two trivial patches with different approaches to prevent
> the segfault as demonstrated by lol-ffplay.ogm.

[...]
-                if (ost->video_resample)
+                if (ost->video_resample && ost->img_resample_ctx)
                     sws_freeContext(ost->img_resample_ctx);
I think the real bug here is that ost->video_resample != 0, but
ost->img_resample_ctx == NULL. So, this looks more a workarond than a
real fix. I suspect the problem is a missing check for errors
somewhere... I'll have a look later.

[...]
void sws_freeContext(struct SwsContext *ctx)
{
+    if (!ctx)
+        return;
I do not know if calling sws_freeContext(NULL) is a bug or not... So,
maybe committing this code is the right thing to do.
But I'd prefer to fix the calling code anyway. I'll check ffmpeg.c
during the lunch break.

			Thanks,
				Luca
-- 
_____________________________________________________________________________
Copy this in your signature, if you think it is important:
                               N O    W A R ! ! !

Home - News ( United States | United Kingdom | Italy | Germany ) - Football scores

Showing content from https://ffmpeg.org/pipermail/ffmpeg-devel/2007-January/027524.html below:

[Ffmpeg-devel] [PATCH] Fix for the lol-ffplay.ogm testcase