RetroSearch Browse

Sat Jan 13 19:45:45 CET 2007 · https://ffmpeg.org/pipermail/ffmpeg-devel/2007-January/027349.html

Hi

Reimar D?ffinger wrote:
> Hello,
> On Fri, Jan 12, 2007 at 11:06:06PM +0100, Reimar D?ffinger wrote:
>> I think this should really be done, since at least in one case we were
>> even writing into the thing returned by the resolving function without
>> even checking the type.
>> Does attached patch look good to you?
> 
> Update: we discovered that adding AnyType is actually not needed (yet?).
> 
> Greetings,
> Reimar D?ffinger
> 
> 
> [...]
>  
>              for (k = 0; k < mxf->packages_count; k++) {
> -                if (!(temp_package = mxf_resolve_strong_ref(mxf, &mxf->packages_refs[k]))) {
> +                if (!(temp_package = mxf_resolve_strong_ref(mxf, &mxf->packages_refs[k], SourcePackage))) {
>                      av_log(mxf->fc, AV_LOG_ERROR, "could not resolve package strong ref\n");
> -                    return -1;
> +                    continue;
>                  }

remove av_log, else it will be print if MaterialPackage ref is before
SourcePackage ref, and that's not an error.

looks ok besides that.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312

Home - News ( United States | United Kingdom | Italy | Germany ) - Football scores

Showing content from https://ffmpeg.org/pipermail/ffmpeg-devel/2007-January/027349.html below:

[Ffmpeg-devel] [PATCH] respect type when resolving MXF strong ref