RetroSearch Browse

Sun Jan 7 23:03:41 CET 2007 · https://ffmpeg.org/pipermail/ffmpeg-devel/2007-January/027143.html

On Sunday 07 January 2007 02:30, Michael Niedermayer wrote:
> > Index: libavcodec/armv4l/mpegvideo_arm.c
> > ===================================================================
> > --- libavcodec/armv4l/mpegvideo_arm.c	(revision 7409)
> > +++ libavcodec/armv4l/mpegvideo_arm.c	(working copy)
> > @@ -24,10 +24,13 @@
> >  #include "../avcodec.h"
> >
> >  extern void MPV_common_init_iwmmxt(MpegEncContext *s);
> > +extern void MPV_common_init_armv5te(MpegEncContext *s);
> >
> >  void MPV_common_init_armv4l(MpegEncContext *s)
> >  {
> > -#ifdef HAVE_IWMMXT
> > +#if defined(HAVE_IWMMXT)
>
> cosmetical change

OK, reverted this change

> > +/* GCC 3.1 or higher is required to support symbolic names in assembly
> > code */ +#if (__GNUC__ > 3) || ((__GNUC__ == 3) && (__GNUC_MINOR__ >= 1))
>
> i assume theres no platform with arm and only gcc 2.95 ?

I asked this question on #oe channel at irc.freenode.net and got information
that some images for Sharp Zaurus still use gcc 2.95, so it is better to keep
this ifdef. But anyway, most of linux handhelds are using up to date versions
of gcc.

On Sunday 07 January 2007 01:08, Diego Biurrun wrote:
> State what the file does, i.e. provide optimized functions for MPEG
> decoding or encoding.  Add your name with a copyright year and say what
> it is based on, possibly with some more copyright statements.

OK, changed copyright header a bit. Maybe it is better now.

Also added references to some docs (ARM architecture reference manual, and
optimization guide for ARM9E) which may be interesting for those who would 
like to work on ARM optimizations, or just may want to check existing asm
code. It took me a while to find this documentation, so it may be useful
to have these references in comments.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mpegvideo_armv5te_try3.diff
Type: text/x-diff
Size: 9582 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070108/95ee5762/attachment.diff>

Home - News ( United States | United Kingdom | Italy | Germany ) - Football scores

Showing content from https://ffmpeg.org/pipermail/ffmpeg-devel/2007-January/027143.html below:

[Ffmpeg-devel] [PATCH] Optimization of 'dct_unquantize_h263_intra' for ARM (armv5te) (try2)