A type derived from Stream overrides ReadAsync(Byte[], Int32, Int32, CancellationToken) but does not override ReadAsync(Memory<Byte>, CancellationToken). Or, a type derived from Stream overrides WriteAsync(Byte[], Int32, Int32, CancellationToken) but does not override WriteAsync(ReadOnlyMemory<Byte>, CancellationToken).
Rule descriptionThe memory-based ReadAsync
and WriteAsync
methods were added to improve performance, which they accomplish in multiple ways:
ValueTask
and ValueTask<int>
instead of Task
and Task<int>
, respectively.In order to realize these performance benefits, types that derive from Stream must provide their own memory-based implementation. Otherwise, the default implementation will be forced to copy the memory into an array in order to call the array-based implementation, resulting in reduced performance. When the caller passes in a Memory<T> or ReadOnlyMemory<T> instance that's not backed by an array, performance is affected more.
How to fix violationsThe easiest way to fix violations is to rewrite your array-based implementation as a memory-based implementation, and then implement the array-based methods in terms of the memory-based methods.
When to suppress warningsIt's safe to suppress a warning from this rule if any of the following situations apply:
Stream
subclass will only ever use the array-based methods.Stream
subclass has dependencies that don't support memory-based buffers.If you just want to suppress a single violation, add preprocessor directives to your source file to disable and then re-enable the rule.
#pragma warning disable CA1844
// The code that's violating the rule is on this line.
#pragma warning restore CA1844
To disable the rule for a file, folder, or project, set its severity to none
in the configuration file.
[*.{cs,vb}]
dotnet_diagnostic.CA1844.severity = none
For more information, see How to suppress code analysis warnings.
See alsoRetroSearch is an open source project built by @garambo | Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4