Home - News ( United States | United Kingdom | Italy | Germany ) - Football scores

Showing content from https://bugzilla.mozilla.org/1921634 below:

Extensions shortcuts CSS needs to be cleaned up and modernized

This bug is publicly visible.

Steps to reproduce:

This bug report was spun out of code review feedback in D217920. Styles in toolkit/mozapps/extensions/content/shortcuts.css need some cleanup and could take advantage of nesting. The below comments describe the changes to be made.

dao:

While you're adding a new rule, could you please nest all of the above in the top .shortcut.card rule? In case you're not familiar with CSS nesting, the selectors should become &:first-of-type, &:hover, &.focused-extension, and .card-heading-icon.

mdmower:

While I'm not opposed to this change request, are you sure this is the right changeset to introduce the change? It's a bit of a rabbit hole. For example, I could point out that the :first-of-type rule likely never used because of sibling element div.error-message preceding the first div.shortcut.card. And then the :hover rule for the card should probably be removed and card-no-hover class applied to shortcut cards instead to make use of common-shared.css styles. And then maybe those .error-message-icon, .error-message-label, etc. rules should be nested in .error-message. It seems like a dedicated cleanup ticket would be a better place to make these changes. If you still want this done, though, I'll do it.

dao:

Could you please file a followup bug then? Thanks!

Actual results:

Styles accumulated tech debt.

Expected results:

Styles were maintained.

RetroSearch is an open source project built by @garambo | Open a GitHub Issue

Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo

HTML: 3.2 | Encoding: UTF-8 | Version: 0.7.3