RetroSearch Browse

Home - News ( United States | United Kingdom | Italy | Germany ) - Football scores

Showing content from https://bugzilla.mozilla.org/1755647 below:

RDM doesn't fire change event of screen.orientation

Closed Bug 1755647 Opened 3 years ago Closed 5 months ago

RDM doesn't fire change event of screen.orientation

RDM doesn't fire change event of screen.orientation

Performance Impact a11y-review Webcompat Priority Accessibility Severity Webcompat Score Tracking Status firefox135 --- fixed Tracking Status relnote-firefox firefox-esr115 firefox-esr128 firefox135 firefox138 firefox139 firefox140 Reset Assignee to default

Bug Flags:

behind-pref firefox-backlog sec-bounty sec-bounty-hof in-qa-testsuite in-testsuite qe-verify

This bug is publicly visible.

What were you doing?

https://makotokato.github.io/demo/orientation.html
Use RDM in devtools
Click rotation icon

What happened?

orientationchange event on window object is fired, but change event on screen.orientation object isn't fired.

What should have happened?

change event on screen.orientation object isn't fired.

I guess that we should simulate change event in simulateScreenOrientationChange or _setRDMPaneOrientation

Nicolas, for investigation

Flags: needinfo?(nchevobbe)

Flags: needinfo?(nchevobbe) → needinfo?(mtigley)

I can take a look into this. Thanks Nicolas!

Assignee: nobody → mtigley

Status: NEW → ASSIGNED

Flags: needinfo?(mtigley)

nsGlobalWindowInner::Orientation seems like it won't look at the BrowsingContext orientation either.

Can we do the browsingcontext orientation thing as a sort-of override rather than keeping the values stored in the browsing context for all documents? That might be simpler.

(In reply to Emilio Cobos Álvarez (:emilio) from comment #5)

nsGlobalWindowInner::Orientation seems like it won't look at the BrowsingContext orientation either.

Can we do the browsingcontext orientation thing as a sort-of override rather than keeping the values stored in the browsing context for all documents? That might be simpler.

If I remember correctly, the orientation values were stored on the browsing context so that they persisted across refreshes while in RDM. I'm not entirely sure if there's now/already another way to do this.

Sure, and that's totally fine. My point is that right now we're treating the BrowsingContext values as the source of truth even when RDM is disabled. It'd be slightly easier to follow if this worked like other overrides, e.g.:

if (Maybe<uint16_t> angle = bc->GetOverrideAngle()) {
  return *angle;
}
return ScreenAngle();

But anyways I guess that's sort of an implementation detail that can be changed at any time :)

The bug assignee is inactive on Bugzilla, so the assignee is being reset.

Assignee: mtigley → nobody

Status: ASSIGNED → NEW

The change event is fired in ResponseActor.dispatchOrientationChangeEvent, along side the orientationchange event.

Assignee: nobody → l1589002388

Status: NEW → ASSIGNED

Attachment #9439990

- Attachment description: Bug 1755647: fire change event on window.screen.orientation. r=jdescottes → Bug 1755647 - Fire change event on window.screen.orientation. r=jdescottes

Attachment #9440263

- Attachment description: Bug 1755647: Test for firing screen orientation change event. r=nchevobbe → Bug 1755647 - Fire change event on window.screen.orientation. r=nchevobbe.

Attachment #9439990

- Attachment description: Bug 1755647 - Fire change event on window.screen.orientation. r=jdescottes → Bug 1755647 - Fire change event on window.screen.orientation. r=nchevobbe.

RetroSearch is an open source project built by @garambo | Open a GitHub Issue

Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo

HTML: 3.2 | Encoding: UTF-8 | Version: 0.7.3