Showing content from http://mail.python.org/pipermail/python-dev/attachments/20150323/a6677be0/attachment.html below:
<p dir="ltr"><br>
On 22 Mar 2015 19:22, "Serhiy Storchaka" <<a href="mailto:storchaka@gmail.com">storchaka@gmail.com</a>> wrote:<br>
><br>
> On 21.03.15 13:46, Nick Coghlan wrote:<br>
>><br>
>> On 19 March 2015 at 19:28, Serhiy Storchaka <<a href="mailto:storchaka@gmail.com">storchaka@gmail.com</a>> wrote:<br>
>>><br>
>>> Here is list of my ready for review patches. It is incomplete and contains<br>
>>> only patches for which I don't expect objections or long discussion. Most<br>
>>> of them are relative easy and need only formal review. Most of them wait<br>
>>> for a review many months.<br>
>><br>
>><br>
>> It's worth noting that If there are changes you feel are genuinely low<br>
>> risk, you can go ahead and merge them based on your own commit review<br>
>> (even if you also wrote the original patch).<br>
><br>
><br>
> Yes, but four eyes are better than two eyes. I make mistakes. In some issues I hesitate about documentation part. In some issues (issue14260 and issue22721) I provided two alternative solutions and need a tip to choose from them. While I am mainly sure about the correctness of the patch, I'm often hesitate about the direction. Is the bug worth fixing? Is the new feature worth to be added to Python?</p>
<p dir="ltr">Aye, agreed - those are the kinds of cases where I'd nudge folks for a review as well. Committing directly is something I'd only do where I'm already entirely confident the change is an improvement over the status quo.</p>
<p dir="ltr">However, now that I think about it further, it's very rare for me to be completely confident in a change without another core dev at least giving a +1 on the general idea.</p>
<p dir="ltr">> Thanks Alexander, Amaury, Benjamin, Berker, Demian, Ãric, Ethan, Martin, Paul, Victor and others that responded on my request.</p>
<p dir="ltr">Indeed! One of the things I'm actually hoping to achieve through PEPs like 474 & 462 is to get to a point where we can better acknowledge and thank folks for all the work that goes into patch reviews :)</p>
<p dir="ltr">Cheers,<br>
Nick.<br></p>
<p dir="ltr">><br>
><br>
> _______________________________________________<br>
> Python-Dev mailing list<br>
> <a href="mailto:Python-Dev@python.org">Python-Dev@python.org</a><br>
> <a href="https://mail.python.org/mailman/listinfo/python-dev">https://mail.python.org/mailman/listinfo/python-dev</a><br>
> Unsubscribe: <a href="https://mail.python.org/mailman/options/python-dev/ncoghlan%40gmail.com">https://mail.python.org/mailman/options/python-dev/ncoghlan%40gmail.com</a><br>
</p>
RetroSearch is an open source project built by @garambo
| Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4