RetroSearch Browse

Home - News ( United States | United Kingdom | Italy | Germany ) - Football scores

Showing content from http://mail.python.org/pipermail/python-dev/attachments/20090403/5db48395/attachment.htm below:

<div class="gmail_quote">(cross-posting back to python-dev to finalize discussions) 2009/4/2 Guido van Rossum <<a href="mailto:guido@python.org">guido@python.org</a>> [...] <blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div><div class="h5">> The problem you report: 
>> 
>> Â try: 
>> Â Â ... 
>> Â except OSWinError: 
>> Â Â ... 
>> Â except OSLinError: 
>> Â Â ... 
>> 
> 
> Would be solved if both OSWinError and OSLinError were always defined in 
> both Linux and Windows Python.Â Programs could be written to catch both 
> OSWinError and OSLinError, except that on Linux OSWinError would never 
> actually be raised, and on Windows OSLinError would never occur.Â Problem 
> solved. 
 
</div></div>Yeah, but now you'd have to generate the list of exceptions (which 
would be enormously long) based on the union of all errno codes in the 
universe. 
 
Unless you only want to do it for some errno codes and not for others, 
which sounds like asking for trouble. 
 
Also you need a naming scheme that works for all errnos and doesn't 
require manual work. Frankly, the only scheme that I can think of that 
could be automated would be something like OSError_ENAME. 
 
And, while OSError is built-in, I think these exceptions (because 
there are so many) should not be built-in, and probably not even live 
in the 'os' namespace -- the best place for them would be the errno 
module, so errno.OSError_ENAME. 
<div class="im"> 
> The downsides of this?Â I can only see memory, at the moment, but I might be 
> missing something. 
 
</div>It's an enormous amount of work to make it happen across all 
platforms. And it doesn't really solve an important problem.</blockquote><div> I partially agree.Â It will be a lot of work.Â I think the problem is valid, although not very important, I agree. Â </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
 
<div class="im"> 
> Now just one final word why I think this matters.Â The currently correct way 
> to remove a directory tree and only ignore the error "it does not exist" is: 
> 
> try: 
> Â Â Â shutil.rmtree("dirname") 
> except OSError, e: 
> Â Â Â if errno.errorcode[e.errno] != 'ENOENT': 
> Â Â Â Â Â Â raise 
> 
> However, only very experienced programmers will know to write that correct 
> code (apparently I am not experienced enought!). 
 
</div>That doesn't strike me as correct at all, since it doesn't distinguish 
between ENOENT being raised for some file deep down in the tree vs. 
the root not existing. (This could happen if after you did 
os.listdir() some other process deleted some file.)</blockquote><div> OK.Â Maybe in a generic case this could happen, although I'm sure this won't happen in my particular scenario.Â This is about a build system, and I am assuming there are no two concurrent builds (or else a lot of other things would fail anyway). 
 </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
 
A better way might be 
 
try: 
Â shutil.rmtree(<dir>) 
except OSError: 
Â if os.path.exists(<dir>): 
Â raise</blockquote><div> Sure, this works, but at the cost of an extra system call.Â I think it's more elegant to check the errno (assuming the corner case you pointed out above is not an issue). </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">

Though I don't know what you wish to happen of <dir> were a dangling symlink. 
<div class="im"> 
> What I am proposing is that the simpler correct code would be something 
> like: 
> 
> try: 
> Â Â Â shutil.rmtree("dirname") 
> except OSNoEntryError: 
> Â Â Â pass 
> 
> Much simpler, no? 
 
</div>And wrong. 
<div class="im"> 
> Right now, developers are tempted to write code like: 
> 
> Â Â Â shutil.rmtree("dirname", ignore_errors=True) 
> 
> Or: 
> 
> try: 
> Â Â Â shutil.rmtree("dirname") 
> except OSError: 
> Â Â Â pass 
> 
> Both of which follow the error hiding anti-pattern [1]. 
> 
> [1] <a href="http://en.wikipedia.org/wiki/Error_hiding" target="_blank">http://en.wikipedia.org/wiki/Error_hiding</a> 
> 
> Thanks for reading this far. 
 
</div>Thanks for not wasting any more of my time.</blockquote></div> OK, I won't waste more time.Â If this were an obvious improvement beyond doubt to most people, I would pursue it, but since it's not, I can live with it. 
 Thanks anyway, -- Gustavo J. A. M. Carneiro INESC Porto, Telecommunications and Multimedia Unit "The universe is always one step beyond logic." -- Frank Herbert

RetroSearch is an open source project built by @garambo | Open a GitHub Issue

Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo

HTML: 3.2 | Encoding: UTF-8 | Version: 0.7.4