RetroSearch Browse

Wed Apr 18 16:08:10 CEST 2012 · http://mail.python.org/pipermail/python-dev/2012-April/118846.html

We're seeing segfuilts on the buildbots now.  Example:

http://www.python.org/dev/buildbot/all/builders/x86%20Ubuntu%20Shared%203.x/builds/5715

On Wed, 18 Apr 2012 23:39:34 +1000, Nick Coghlan <ncoghlan at gmail.com> wrote:
> On Wed, Apr 18, 2012 at 11:31 PM, brian.curtin
> <python-checkins at python.org> wrote:
> > - Â  Â if (name == NULL)
> > + Â  Â if (name == NULL) {
> > + Â  Â  Â  Â Py_INCREF(Py_None);
> > Â  Â  Â  Â  name = Py_None;
> > + Â  Â }
> 
> A slightly more traditional way to write that would be:
> 
>     name = Py_None;
>     Py_INCREF(name);
> 
> > - Â  Â if (path == NULL)
> > + Â  Â if (path == NULL) {
> > + Â  Â  Â  Â Py_INCREF(Py_None);
> > Â  Â  Â  Â  path = Py_None;
> > + Â  Â }
> 
> Ditto.
> 
> >
> > Â  Â  Py_INCREF(msg);
> > - Â  Â PyTuple_SetItem(args, 0, msg);
> > + Â  Â PyTuple_SetItem(args, 0, NULL);//msg);
> 
> However, *this* looks a lot more suspicious... accidental commit of
> debugging code?
> 
> (if not for spotting this last problem, I wouldn't have even mentioned
> the first two)
> 
> Cheers,
> Nick.
> 
> -- 
> Nick CoghlanÂ Â  |Â Â  ncoghlan at gmail.comÂ Â  |Â Â  Brisbane, Australia
> _______________________________________________
> Python-Dev mailing list
> Python-Dev at python.org
> http://mail.python.org/mailman/listinfo/python-dev
> Unsubscribe: http://mail.python.org/mailman/options/python-dev/rdmurray%40bitdance.com

Home - News ( United States | United Kingdom | Italy | Germany ) - Football scores

Showing content from http://mail.python.org/pipermail/python-dev/2012-April/118846.html below:

Fix email post-commit review comments.