From: "Jeremy Hylton" <jeremy@zope.com> > I also checked in a probable fix for the problem Tim reported when > running test_strptime, test_logging, and test_time in that order. I'm > not confident that the fix is correct. Basically, it tries to restore > the locale to its original value when test_logging finishes. Can > someone who understands locales review that change? Please forgive if I'm stating the obvious, but the failing tests are the ones that should be changed, not the ones that are "polluting" the environment. When I was working on test_warnings.py, I had found that other tests had set warning filters without clearing them. Rather than alter the polluters, I fixed test_warnings so it either worked with existing filters or temporarily set its own -- that way the test would work in any combination with other tests. In a way, the polluters were helpful because they helped flag an unnecessary state dependency in the test_suite. So if test_strptime is going to be locale dependent, it should temporarily set what it expects to find. Raymond Hettinger ################################################################# ################################################################# ################################################################# ##### ##### ##### ################################################################# ################################################################# #################################################################
RetroSearch is an open source project built by @garambo | Open a GitHub Issue
Search and Browse the WWW like it's 1997 | Search results from DuckDuckGo
HTML:
3.2
| Encoding:
UTF-8
| Version:
0.7.4